Unterminated comments in include scripts
3 posters
:: Community Input :: Bug Reports
Page 1 of 1
Unterminated comments in include scripts
This wasn't even an issue really until recently, but with SkywingvL's release of the Advanced Script Compiler , which has some more careful script checking than the old Bioware compiler, I ran into this. A number of the CEP scripts have comment blocks at the end which are un-terminated, i.e. there is an opening "/*" with no closing "*/". For example:
- Code:
/*
PrintString("+================================================+");
PrintString("+========== Builders' Compendium ==========+");
PrintString("+=== ===+");
PrintString("+=== A 1st Order of Role-Players' Creation ===+");
PrintString("+========== www.1stOrder.net ==========+");
PrintString("+================================================+");
Re: Unterminated comments in include scripts
Yea, I have seen that before. Odd that whoever wrote those comments did it in such a manner but each scripter has their own flavor.
Re: Unterminated comments in include scripts
Actually, this is much less prevelent than I thought. After taking all the scripts out of CEP 2.4 to recompile them, only that one (zep_inc_1st_rp.nss) has an un-terminated comment. It just got included through zep_inc_phenos and caused a number of warnings. So it should be very little work to clean up. The rest of the CEP scripts built pleasantly cleanly.
The only other thing of significance that the ACS pointed out was:
One last thing of note. The CEP has a useful naming convention, i.e. using the zep_ prefix to group the CEP associated functions and help prevent name collisions. It's also useful for working with the CEP products by themselves when mixed with others, such as in temp0. For instance it would be nice to be able to do "ScriptCompiler zep_*.nss" to rebuild the CEP scripts. Quite a few scripts have deviated from this convention over time and it would be nice where possible to try and get them back on course if possible. Here is a list of "non-canon" script names in the 2.4 hak's:
The only other thing of significance that the ACS pointed out was:
- Code:
horse_dm_mount.nss(9): Warning: NSC6017: "oPC" referenced in initialization expression
- Code:
object oPC = GetLocalObject(oPC,"ITEM_ACTIVATOR");
- Code:
cut_and_paste.ncs
trap_readmecep21.ncs
zep_cw_inc.ncs
zep_inc_craft.ncs
crp_inc_language.ncs
- Code:
crp_inc_control.nss
- Code:
default.nss
nw_o2_coninclude.nss
x0_i0_treasure.nss
One last thing of note. The CEP has a useful naming convention, i.e. using the zep_ prefix to group the CEP associated functions and help prevent name collisions. It's also useful for working with the CEP products by themselves when mixed with others, such as in temp0. For instance it would be nice to be able to do "ScriptCompiler zep_*.nss" to rebuild the CEP scripts. Quite a few scripts have deviated from this convention over time and it would be nice where possible to try and get them back on course if possible. Here is a list of "non-canon" script names in the 2.4 hak's:
- Code:
_on_playerchat.nss
blockdoor.nss
colors_inc.nss
cut_and_paste.nss
cz_realtroll_sp.nss
cz_realtroll_ud.nss
dmts_common_inc.nss
dragon_dmount.nss
dragon_mount.nss
fly_start.nss
fly_stop.nss
open_store.nss
pointthefinger.nss
pointthefingertl.nss
sfps_inc.nss
sfps_on_close.nss
sfps_on_open.nss
sfrm_exit.nss
sparky_inc.nss
spawner_onenter.nss
spawner_onexit.nss
tbx0_banjo01.nss
tbx0_social_conv.nss
tbx0_social_hb.nss
tbx0_social_ud.nss
tk_ai_demilich.nss
wyrmling_convo.nss
wyrmling_death.nss
wyrmling_dismiss.nss
wyrmling_spawn.nss
z217_behold.nss
zmal_pcl_list.nss
- Code:
conv_*
df_*
dm_*
enc_*
horse_*
mali_*
mcs_*
run_*
trap_*
z_*
Re: Unterminated comments in include scripts
Just looking at that Advanced Script Compiler you linked above - the post says its for NWN2.
Guest- Guest
Re: Unterminated comments in include scripts
It also works for NWN, and it's used to replace the default compiler if you are using NWNTX (virusman's Neverwinter Nights Toolset Extender).Pstemarie wrote:Just looking at that Advanced Script Compiler you linked above - the post says its for NWN2.
Re: Unterminated comments in include scripts
The Amethyst Dragon wrote:It also works for NWN, and it's used to replace the default compiler if you are using NWNTX (virusman's Neverwinter Nights Toolset Extender).Pstemarie wrote:Just looking at that Advanced Script Compiler you linked above - the post says its for NWN2.
Thanks for the clarification. I've always used the PRC script compiler when the toolset's compiler couldn't handle things anymore. I don't use NWNTX as its not well documented - at least that I could find - and appears quite intimidating.
Guest- Guest
:: Community Input :: Bug Reports
Page 1 of 1
Permissions in this forum:
You cannot reply to topics in this forum
|
|